fix: ignore stray oauth callback requests - #481
Merged
Colin Francis (colifran) merged 4 commits intoJul 29, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 8b2faac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Colin Francis (colifran)
approved these changes
Jul 29, 2026
Colin Francis (colifran)
left a comment
Colin Francis (colifran)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good - thanks HwangJohn!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/favicon.ico/callbackrequestsWhy
Browsers and local tooling can send extra requests to the loopback OAuth server before the provider redirect completes. Those requests should not fail the login attempt before the real callback arrives.
No dedicated issue; found during an OAuth callback hardening sweep.
Testing
corepack pnpm exec vitest run test/oauth-callback-server.test.tspassedcorepack pnpm run format:checkpassedcorepack pnpm run lint:checkpassedcorepack pnpm run typecheckpassedgit diff --checkpassedcorepack pnpm testwas attempted on Windows and still fails outside this change in existingtest/env-behavior.test.tsHOME/permission assertions plus Mermaid/jsdom timeout tests